[alexg]

Again, I am unable to reproduce this on exchange 0.5.3-beta and wallets 3.9.2. To be clear:

1. In all my tests it is impossible to buy a coin without having a base currency balance, and impossible to sell a coin without a quote currency balance.
2. Moreover, if any error occurs, the DB transaction is rolled back, so there is no executed trade.

You mentioned that you are testing in a private website.

Is it possible for you to give me access to your test server and give me instructions on how to reproduce the problem? If you can, please let me know, because I am running out of ideas.

If you cannot give me access to your test server, could you please send me complete instructions of what you did, so I can test on my machine? I would need to know the amount, exchange rate and direction (bid/ask) of the initial order, and the same details of the matching order that is performed by the second user, who has no balance.

If you can point me to one example of this defect, I will be able to provide a solution ASAP.

thank you

with regards

[alexg]

The end user experience is what matters at the end of the day.

But as a backend developer, my worry is not to break the separation of concerns principle. I have provided a payment gateway, and all that a payment gateway does is execute payments. A payment gateway does not do anything else.

If you believe that the user experience of WCMp is not good enough, then that is an issue with that particular plugin. Why do you feel that an email should be sent only when the payment is done via a cryptocurrency, and not when it is done via, say, PayPal?

I would recommend that instead you enable admin approval for withdrawals (enabled by default). Then you can have a final say when one of your vendors requests to withdraw funds.

Hope this helps.

with regards

[alexg]

@tfontoura Hello and thank you for this question. I get asked this a lot, so I decided to add it to a brand new FAQ section to the homepage of the CoinPayments adapter.

TL;DR You should use the ShapeShift extension.

with regards

P.S. Please open a new thread for any new questions or issues that you have. Thank you!

[alexg]

Hello,

About the child theme, what you are experiencing is a race condition. Sometimes your css is loaded first and sometimes after the plugin’s css. Normally as a programmer when you enqueue stylesheets in WordPress you can specify a graph of dependencies between various assets so that this does not happen. In this case, the solution would be to correct the specificity of the rule so that it always overrides whatever rules already apply.

This is not necessary, After some testing I have determined that your suggestion does not cause problems in most themes and I will include it in the next patch.

Thank you. Hope you have great holidays.

with regards

[alexg]

Hello,

Yes, this is something that I would like to implement in the future.

Ideally the admin should be able to select cryptocurrencies that are available for payment and the vendor should be able to choose one of those, if there is enough balance.

Thank you.

with regards

[alexg]

Hello,

If you wish to disable withdrawals, you already have a number of ways available to do this. This would make sense in a site destined to be a multi-vendor e-shop.

Blocking payments is not something that this plugin should do. What does WCMp do in this situation with other payment gateways? The same should happen with this gateway.

This is not a problem specific to cryptocurrencies but should apply to all payment gateways. What do you think?

with regards

[alexg]

Hello,

Thank you so much for your wishes and your feedback. I hope you are having a great time these days.

Could you please show me a screenshot of the problem?

The way you describe it, it sounds like something that the developers of the WC Marketplace plugin should address. I did not create any payments table or other UI, only a payment gateway which handles payments in the backend.

In any case, if possible, please send me a screenshot.

thanks

with regards

[alexg]

Thank you for contributing this CSS.

You should never be editing the plugin or any theme, for the reason that you describe above. If you need to add any CSS rules simply add it as a child theme to your main theme. This way the changes do not get overwritten each time. There is a reason that CSS is called “Cascading”. You can cascade multiple style sheets 😉

Having said this, I have already considered in the past making the headers fixed, and this caused some problems with some themes. I will review this again and I might add it as an option.

with regards

[alexg]

Hello,

Yes, this is correct.

The exchange does not have orders, and therefore does not have prices. Prices are derived from an active market, if there is no market, there are no prices.

Prices are the point at which a buy order meets a sell order. Unless some trades have been executed in your market, there won’t be any prices (and therefore no candlesticks).

Hope this is clear. Let me know if you have more questions about this.

with regards

[alexg]

Hello,

Sure, I joined the group but I am not active on telegram. If members can help each other that’s great, it makes my life easier!

But if people want to contact, they will still need to find me here on the forums or at my email.

with regards

[alexg]

Thank you.

Based on your finings I will investigate, to figure out if the plugin can somehow warn the user ahead if this issue arises.

One more question – did you use the static templates of the shortcodes? If so then it makes sense to exclude that page. If not, then I would expect the solution to be to exclude the JSON API from your cache.

thanks again and happy holidays

[alexg]

Hello,

I have added the ability to disable trading per each market individually in the exchange extension version 0.5.3-beta. You will find the functionality at the “Markets” tab.

About the other functionality you requested, I have implemented it as a separate extension and will release it soon. It will be possible to disable withdrawals and internal transfers individually per coin. It will not be possible to disable deposits, as these are external to the system.

Thank you for your suggestions, these are features that I believe will be useful to a large number of users.

with regards

[alexg]

Hello,

I have just now released 0.5.3-beta which includes a few bugfixes, including one that I believe was causing the “insufficient funds” message you saw. There is also a new feature, you can now disable buy, sell, and cancel operations individually per market.

Transactions with very small amounts were previously evading the check for minimum order size due to rounding, this has now been fixed. Any existing orders of 0 amount will eventually be marked as completed as a part of normal trading.

You mentioned that you have users. Please keep in mind that the exchange is still in beta, which means not production ready. Use at your own risk.

I was not able to detect a condition where an order is executed even after triggering an error.

Thank you for your help in identifying these problems, I hope this new version addresses the issues you identified. Please let me know if it does not.

with regards

[alexg]

Hello,

I have just now released 0.5.3-beta which includes a few bugfixes, including one that I believe was causing the “insufficient funds” message you saw. There is also a new feature, you can now disable buy, sell, and cancel operations individually per market. I was not yet able to identify a condition where fees are applied when they are set to zero.

kind regards

[alexg]

I have now identified a bug that is probably related to causing the “insufficient funds” message. I am still not sure why fees would be applied when you set them to zero. I will look at this again tomorrow.

[Author]

Posts