Forum Replies Created
-
Posts
-
Hello,
Unfortunately the plugin does not record the actual amount that was paid in fees to the blockchain network. The plugin only records the fees that the user sees, which should be more than the actual fee. The reason is that not all wallets report back the actual fees paid and therefore the transaction DB schema and coin adapter API are not designed to hold that information.
If you know how much your wallet pays in fees in a typical transaction, you can calculate this. Go to the admin dashboard and you will see sums of fees paid and transaction counts for the last day, week, month, and year.
For example, say that there have been 10 BTC withdrawals, and the sum of fees paid was 0.00500000 using CoinPayments. We know that CoinPayments uses a fee of 0.00040000 (or 40k satoshis) per BTC withdrawal. Therefore, the fees that remain with your site are 0.00500000 – 10*0.0004 = 0.001 BTC.
On the other hand, the fees that you see paid for internal transfers is accurate, as shown in the admin dashboard. All the fees paid for internal transfers are yours since you don’t pay a network fee for those.
The same goes for full node wallets, you just need the
txfeevalue that you use in your.conffile to do the same calculation.Hope this helps. Let me know if you have any more questions about this.
with regards
Yep, it’s explained in the coin adapter settings.
For reference, fixed fees are an amount that is charged on each transaction. Proportional means that the transacted amount is multiplied by the fee “proportion” and therefore the fee paid for the transaction is a fraction of the total transacted amount.
From the documentation’s glossary section:
Fees are subtracted from user accounts and remain with the wallet. For every coin, there is one wallet that is split between all users with the has_wallets capability. In the case of withdrawals, the fees are first used to pay for the blockchain’s network fees, and any remaining fees stay with your site’s wallet. In the case of internal transfers between users, the entirety of the paid fees is subtracted from the sender’s balance and remains with your wallet, since there is no blockchain transaction. When you visit the *coin adapters* screen in your admin area, you can see the total of user balances for each coin, and the balance of the wallet. These amounts do not have to be the same. As users perform transactions and pay fees, these fees will be subtracted from the user balances, but not from the wallet balance.
I did some more tests and still cannot figure out why your first address did not work. Withdrawals in the CoinPayments adapter are a stable feature that was developed a long time ago and has been working fine over the years; it’s unlikely that there’s any bug in the adapter. Did you attempt a test withdrawal from the platform to your address?
Thank you.
I understand your argument, but I have not reached a decision on what to do on this. Doing so would take too much time right now that I do not have.
In the meantime, you could use text to explain to your users that they cannot deposit/withdraw custom coins, or simply do not use custom coins.
When I arrive at a decision I will let you know.
with regards
Here’s an idea:
Login to CoinPayments, and attempt a test withdrawal to the first address, using the CoinPayments website: https://www.coinpayments.net/index.php?cmd=acct_balances&action=withdraw&coin=BTC
Does the platform accept the address? Or do you get the same error?
The first address you gave is a P2PKH and the second one is P2SH. To read up more on address types, see https://en.bitcoin.it/wiki/Address
If you visit the addresses in a block explorer it usually tells you the type.
https://www.blockchain.com/btc/address/16YCtPK5gWewAbcauTmfsWmUMLJnkn7u2v
https://www.blockchain.com/btc/address/3BMEX3KRRHCGrXQZGpjjWyNeZBNGwe9wV1The problem is that both should work. At least now we know that sending to P2SH addresses works for you.
Did you check for non-printable characters in your transactions? How are you inputting the address? QR code or paste from clipboard? I can’t think of anything else right now. This is a weird error.
OK then, it doesn’t look like a bech32 address. Without having the exact address I cannot verify if it is correct. Did you try withdrawing to several addresses or just one?
In any case, this error comes from the platform, not the plugin.
Check your withdrawal history in CoinPayments, and see if there is any more information there.
Also, check if there were there any whitespaces in the address, or even unprintable characters? Several unicode characters, such as non-breaking white spaces (NBSPs), can sometimes be copied together with the address and can cause havoc.
You may be able to get more information by contacting CoinPayments support. Mention the CPID and they should be able to tell you why the withdrawal failed. If the withdrawal has failed, then the CPID should be in place of the TXID. Additionally, if you login to the platform and go to the withdrawal history, you should be able to see the CPID for your transaction.
Hope this helps.
with regards
Hello,
This error does not originate from the plugin but from the wallet backend.
The CoinPayments API returns “That is not a valid address for that coin!”. Check the format of your withdrawal address (P2PKH, P2SH, or Bech32). Is it compatible with CoinPayments? For example, I am not certain if Bech32 is supported for Bitcoin transactions on CoinPayments.
Try a different address format and see if it makes a difference. Let me know what you found.
with regards
Thank you. Good job.
I also want to do some work on styling the UIS for mobile/responsive, but it’s of secondary priority right now compared to some other stuff. Ideally if you can write your own rules then you will match your theme better than I can. But mobile styling will come to the plugin eventually 🙂
with regards
Hello,
@bigblue Thanks for letting me know. There are no settings. Did you check with one theme or many? This sounds a lot like a CSS issue. Can you show me a screenshot or give me access to a site?
@jamiej I am not sure why you reinstalled wordpress, at the very least you could downgrade to the previous version of the Exchange extension. These things are usually CSS issues. It is near impossible to predict what CSS rules a theme has, I’m just aiming to make something that works with a few standard themes, glad you found a solution. The graph already has the red/green colors that you set in customizer. In a later version I may add more styling controls in customizer.with regards
Hello,
What I am talking about is not a bigger change, only a more general and simpler one. At this time I do not see a need to work on this extension. Once I decide to work on this I will let you know.
with regards
Now that version
1.3.0of the Exchange extension is out, and the chart is implemented using your suggestion, the TradingView lightweight-charts library, the chart is now responsive if you do not specify width/height. When the window resizes, the charts are redrawn to the new available container size.Hello again,
OK it is done! In version
1.3.0of the Exchange extension I’ve used lightweight-charts from TradingView, replacing the old implementation that used techan.js.Thank you for the suggestion, it feels much better now!
This is not to say that techan.js is not a good library, but I never figured out how to control the visible frame using the mouse with it.
with regards
The above styling is now part of version
1.3.0of the Exchange. The dropdowns should appear more uniform across various themes now.OK this requires more thought than I initially believed:
Essentially you want to control which coins are allowed to do any one of the operations move, deposit, withdraw. This requires big changes. If it is to be done, it has to be done for all coins, and in a way that will not require more changes two weeks down the road.
Can you tell me more about your use case? What are you using custom coins for? Is it some type of store credit that does not make sense to deposit/withdraw?
Thank you.
